Skip to content

feat: add tab roles/search role#387

Closed
47PADO47 wants to merge 21 commits intocallstack:mainfrom
padosoft:add-tab-search-role
Closed

feat: add tab roles/search role#387
47PADO47 wants to merge 21 commits intocallstack:mainfrom
padosoft:add-tab-search-role

Conversation

@47PADO47
Copy link
Copy Markdown
Contributor

@47PADO47 47PADO47 commented Jul 12, 2025 •
edited
Loading

PR Description

This pr adds support for ios tab roles

How to test?

Run the app on a mac and go into "sf symbols" example

Screenshots

Simulator Screenshot - iPhone 16 Pro - 2025-07-12 at 18 53 46

simulator_screenshot_C37172EB-9DD1-4D0E-84E4-F7CA1D94BDD1

@47PADO47 47PADO47 changed the title Add tab roles/search role feat: add tab roles/search role Jul 12, 2025
@okwasniewski
Copy link
Copy Markdown
Collaborator

okwasniewski commented Jul 15, 2025

@47PADO47 Thanks for working on this! Can you rebase with latest changes so only the changes adding tab roles are in this PR?

@47PADO47 47PADO47 force-pushed the add-tab-search-role branch from c8094e6 to 44dacd8 Compare July 15, 2025 12:33
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3fcb1e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
react-native-bottom-tabs Minor
@bottom-tabs/react-navigation Minor
@bottom-tabs/expo-template Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@47PADO47 47PADO47 marked this pull request as ready for review July 15, 2025 12:40
@47PADO47
Copy link
Copy Markdown
Contributor Author

47PADO47 commented Jul 15, 2025

done, let me know if anything needs to be changed. i also added a changelog entry, but noticed i forgot to add one for the pr #364. should i create it?

okwasniewski
okwasniewski reviewed Jul 15, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Can you also update documentation for both React Navigation usage and standalone usage?

Comment thread packages/react-navigation/src/types.ts Outdated
Comment thread packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabViewImpl.kt Outdated
Comment thread packages/react-native-bottom-tabs/ios/TabView/NewTabView.swift Outdated
@47PADO47
Copy link
Copy Markdown
Contributor Author

47PADO47 commented Jul 16, 2025 •
edited
Loading

@okwasniewski i think everything's done, what do you say?
also i have no idea why ci keeps failing, the error message is vague and i can easily build the project on my machine without issues

47PADO47 added 21 commits July 18, 2025 14:14
@47PADO47
fix: move LegacyTabView measureView
f3a1a88
@47PADO47
fix: revert move LegacyTabView measureView
06c1b17
@47PADO47
fix: move LegacyTabView measureView
2ee991e
@47PADO47
fix: revert move LegacyTabView measureView
8d2f699
@47PADO47
feat: add role prop
04a2902
@47PADO47
feat: add role handling
4856b54
@47PADO47
feat: add ts props
055a93d
@47PADO47
chore: update example
845ab37
@47PADO47
fix(android): assign role in RCTTabViewImpl
f32e3ce
@47PADO47
chore: run swiftlint
ca0b924
@47PADO47
fix: export TabRole type
c6f6fe6
@47PADO47
chore: add changelog entry
f913f13
@47PADO47
fix(android): remove role prop
1322706
@47PADO47
fix: Update role jsdoc
a6b2aa6
@47PADO47
feat: implement enum TabBarRole
c54c059
@47PADO47
feat: update TabInfo role type
2860e83
@47PADO47
feat: use TabBarRole.convert()
eda7653
@47PADO47
Update Podfile.lock
3f22514 
fix: sync Podfile.lock
@47PADO47
fix: rename tabBarRole to role
8149caf
@47PADO47
feat: update react-navigation docs
0e4ad31
@47PADO47
feat: update standalone docs
3fcb1e5
@47PADO47 47PADO47 force-pushed the add-tab-search-role branch from 1f509ca to 3fcb1e5 Compare July 18, 2025 12:14
@okwasniewski okwasniewski mentioned this pull request Jul 19, 2025
Merged
@okwasniewski
Copy link
Copy Markdown
Collaborator

okwasniewski commented Jul 19, 2025

Thank you for working on this! Merged in #390

@47PADO47 47PADO47 deleted the add-tab-search-role branch July 19, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@okwasniewski okwasniewski okwasniewski left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@47PADO47 @okwasniewski